Skip to content

Commit c3ffbbd

Browse files
committed
Merge pull request #15 from wmde/removephp
Removed ParseValue API module
2 parents 295f105 + 7da029a commit c3ffbbd

File tree

6 files changed

+6
-366
lines changed

6 files changed

+6
-366
lines changed

DataValuesJavascript.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,6 @@
3434
include( __DIR__ . '/src/valueFormatters/resources.mw.php' )
3535
);
3636

37-
// API module registration
38-
$GLOBALS['wgAPIModules']['parsevalue'] = 'ValueParsers\ApiParseValue';
39-
40-
/**
41-
* @deprecated since 0.1 This is a global registry that provides no control over object lifecycle
42-
*/
43-
$GLOBALS['wgValueParsers'] = array();
44-
4537
/**
4638
* Register QUnit test base classes used by test modules in dependent components.
4739
* @see https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules

README.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,8 @@ On [Packagist](https://packagist.org/packages/data-values/javascript):
1111

1212
## Technical debt
1313

14-
TODO: remove dependency on ApiParserValue from the JS so ApiParseValue
15-
can be removed. ApiParseValue is the only PHP class in this package and
16-
is the only thing that depends on the DataValues PHP components.
17-
1814
TODO: write high level description and documentation in this README file.
1915

20-
TODO: make tests runnable without needing MW and a browser
21-
2216
TODO: have tests run on CI
2317

2418
## Release notes

composer.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,11 @@
2626
"irc": "irc://irc.freenode.net/wikidata"
2727
},
2828
"require": {
29-
"composer/installers": ">=1.0.1",
30-
"data-values/interfaces": "~0.1"
29+
"composer/installers": ">=1.0.1"
3130
},
3231
"autoload": {
3332
"files" : [
3433
"DataValuesJavascript.php"
35-
],
36-
"classmap": [
37-
"php/src/"
3834
]
3935
}
4036
}

php/src/ApiParseValue.php

Lines changed: 0 additions & 337 deletions
This file was deleted.

php/tests/bootstrap.php renamed to phpunit.bootstrap.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
}
66

77
$pwd = exec( 'pwd' );
8-
chdir( __DIR__ . '/../..' );
8+
chdir( __DIR__ );
99
passthru( 'composer update' );
1010
chdir( $pwd );
1111

12-
require_once( __DIR__ . '/../../vendor/autoload.php' );
12+
require_once( __DIR__ . '/vendor/autoload.php' );

0 commit comments

Comments
 (0)