Skip to content

Commit 295f105

Browse files
committed
Merge pull request #14 from wmde/decoupletests
Decoupled QUnit tests from ResourceLoader
2 parents dcde964 + a06c7e1 commit 295f105

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+14999
-401
lines changed

.jshintignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
./lib/jquery/*
2+
./lib/qunit/*
3+
./lib/require/*

.jshintrc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@
3636
"valueFormatters",
3737
"valueParsers",
3838
"time",
39-
"util"
39+
"util",
40+
// require.js globals:
41+
"require",
42+
"requirejs",
43+
"define"
4044
]
4145
}

DataValuesJavascript.php

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
$GLOBALS['wgValueParsers'] = array();
4444

4545
/**
46-
* Hook for registering QUnit test cases.
46+
* Register QUnit test base classes used by test modules in dependent components.
4747
* @see https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules
4848
* @since 0.1
4949
*
@@ -55,13 +55,35 @@
5555
array &$testModules,
5656
\ResourceLoader &$resourceLoader
5757
) {
58-
$testModules['qunit'] = array_merge(
59-
$testModules['qunit'],
60-
include( __DIR__ . '/tests/lib/resources.php' ),
61-
include( __DIR__ . '/tests/src/resources.php' ),
62-
include( __DIR__ . '/tests/src/valueFormatters/resources.php' ),
63-
include( __DIR__ . '/tests/src/valueParsers/resources.php' )
58+
59+
$moduleTemplate = array(
60+
'localBasePath' => __DIR__ . '/test',
61+
'remoteExtPath' => '..' . substr( __DIR__, strlen( $GLOBALS['IP'] ) ) . '/tests',
6462
);
6563

64+
$testModuleTemplates = array(
65+
66+
'valueFormatters.tests' => $moduleTemplate + array(
67+
'scripts' => array(
68+
'src/valueFormatters/valueFormatters.tests.js',
69+
),
70+
'dependencies' => array(
71+
'valueFormatters',
72+
),
73+
),
74+
75+
'valueParsers.tests' => $moduleTemplate + array(
76+
'scripts' => array(
77+
'src/valueParsers/valueParsers.tests.js',
78+
),
79+
'dependencies' => array(
80+
'valueParsers.parsers',
81+
),
82+
),
83+
84+
);
85+
86+
$testModules['qunit'] = array_merge( $testModules['qunit'], $testModuleTemplates );
87+
6688
return true;
6789
};

0 commit comments

Comments
 (0)