Skip to content

Updated sample app to use/work with dev (future 6.0) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 13, 2017
Merged

Conversation

wmathurin
Copy link
Owner

No description provided.

@wmathurin
Copy link
Owner Author

Allowed me to reproduce this issue:
forcedotcom/SalesforceMobileSDK-iOS#2319

And to come up with this fix:
forcedotcom/SalesforceMobileSDK-iOS#2324

@wmathurin wmathurin requested a review from bhariharan December 12, 2017 02:19
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "MyUserPicReactNative";
return "ReactNativeTemplate";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be MyUserPicReactNative.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran forcereact to regenerate the app - I will check if there is a bug there.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran forcereact to regenerate the app - I will check if there is a bug there.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -1,8 +1,11 @@
rootProject.name = 'MyUserPicReactNative'
rootProject.name = 'ReactNativeTemplate'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MyUserPicReactNative.

js/UserPic.js Outdated
@@ -89,7 +93,7 @@ module.exports = React.createClass({
},

getUserInfo(callback) {
forceClient.sendRequest('/services/data', '/v36.0/chatter/users/me',
net.sendRequest('/services/data', '/v36.0/chatter/users/me',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch this to v41.0 to be inline with 6.0?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

js/UserPic.js Outdated
@@ -103,7 +107,7 @@ module.exports = React.createClass({
},

uploadPhoto(localPhotoUrl, callback) {
forceClient.sendRequest('/services/data', '/v36.0/connect/user-profiles/' + this.state.userId + '/photo',
net.sendRequest('/services/data', '/v36.0/connect/user-profiles/' + this.state.userId + '/photo',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch this to v41.0 to be inline with 6.0?

@bhariharan
Copy link
Collaborator

👍

@wmathurin wmathurin merged commit 470fbff into master Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants