-
Notifications
You must be signed in to change notification settings - Fork 2
Updated sample app to use/work with dev (future 6.0) #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allowed me to reproduce this issue: And to come up with this fix: |
* Returns the name of the main component registered from JavaScript. | ||
* This is used to schedule rendering of the component. | ||
*/ | ||
@Override | ||
protected String getMainComponentName() { | ||
return "MyUserPicReactNative"; | ||
return "ReactNativeTemplate"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be MyUserPicReactNative
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran forcereact to regenerate the app - I will check if there is a bug there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran forcereact to regenerate the app - I will check if there is a bug there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
android/settings.gradle
Outdated
@@ -1,8 +1,11 @@ | |||
rootProject.name = 'MyUserPicReactNative' | |||
rootProject.name = 'ReactNativeTemplate' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MyUserPicReactNative
.
js/UserPic.js
Outdated
@@ -89,7 +93,7 @@ module.exports = React.createClass({ | |||
}, | |||
|
|||
getUserInfo(callback) { | |||
forceClient.sendRequest('/services/data', '/v36.0/chatter/users/me', | |||
net.sendRequest('/services/data', '/v36.0/chatter/users/me', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we switch this to v41.0
to be inline with 6.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
js/UserPic.js
Outdated
@@ -103,7 +107,7 @@ module.exports = React.createClass({ | |||
}, | |||
|
|||
uploadPhoto(localPhotoUrl, callback) { | |||
forceClient.sendRequest('/services/data', '/v36.0/connect/user-profiles/' + this.state.userId + '/photo', | |||
net.sendRequest('/services/data', '/v36.0/connect/user-profiles/' + this.state.userId + '/photo', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we switch this to v41.0
to be inline with 6.0
?
👍 |
No description provided.