Skip to content

Conversation

DedeHai
Copy link
Collaborator

@DedeHai DedeHai commented Sep 5, 2025

percent FX has transition speed built in, it was just hidden for years...

Summary by CodeRabbit

  • New Features
    • Added ESP32 V4 build variant and optional parallel I2S output toggle in LED settings.
    • Enabled DMX input on ESP32 (IDF4 environments).
  • Improvements
    • Smoother effect timing (up to 250 FPS, unlimited option), more reliable ESP-NOW remote handling, and better memory/board compatibility (ESP32 S2/S3/C3).
    • UI tweaks: pointer-based tooltips, clearer segment controls, palette button visibility, and installed version display.
  • Bug Fixes
    • More consistent primary color handling across buttons, MQTT, Hue, and UI.
    • Stabilized audioreactive peak reset and preset application.
  • Documentation
    • CHANGELOG updates; rotary encoder usermod notes refreshed.
  • Chores
    • Automated release changelog; logs directory ignored; version bumped to 0.15.2-beta1.

Copy link
Contributor

coderabbitai bot commented Sep 5, 2025

Caution

Review failed

Failed to post review comments.

Walkthrough

Adds a release changelog step; updates versioning and CHANGELOG. Introduces ESP32 IDFv4 envs, library upgrades, DMX options, and partition tweaks. Major refactors include bus management (vector-based, parallel I2S support), FX timing/memory, Segment API (setUp→setGeometry), primary color rename (col→colPri), config I/O changes, UI updates, remote handling deferral, and multiple stability fixes.

Changes

Cohort / File(s) Summary
CI Release Workflow
.github/workflows/release.yml
Adds changelog generation step and wires its output to draft release body.
Ignore/Changelog/Version
.gitignore, CHANGELOG.md, package.json
Adds /logs to ignore; updates CHANGELOG builds; bumps package version to 0.15.2-beta1.
Build Scripts
pio-scripts/build_ui.py
Adds Node preflight, runs npm install then build with error handling.
PlatformIO Configs
platformio.ini, platformio_override.sample.ini
Adds ESP32 IDF v4 envs (esp32dev_V4), upgrades libraries, switches AsyncTCP, adds DMX, stack size flags, partitions, AR sample envs and LED macro changes.
Usermods fixes
usermods/BME280_v2/usermod_bme280.h, usermods/audioreactive/audio_reactive.h, usermods/usermod_rotary_brightness_color/usermod_rotary_brightness_color.h, usermods/usermod_v2_rotary_encoder_ui_ALT/usermod_v2_rotary_encoder_ui_ALT.h, usermods/rgb-rotary-encoder/readme.md
BME280 temp unit init; audioreactive peak timing via frame time; use colPri instead of col in rotary modules; update ESP Rotary lib version in docs.
FX Engine Updates
wled00/FX.h, wled00/FX.cpp, wled00/FX_fcn.cpp
Introduces MIN_FRAME_DELAY; Segment API changes (setGeometry, setName, differs const); per-LED buffers and signed loops; timing/show logic refactor; fade/out rewrite; updates Percent mode data string.
Bus Subsystem Refactor
wled00/bus_manager.h, wled00/bus_manager.cpp, wled00/bus_wrapper.h, wled00/const.h
Switch to std::vector busses, const-correct APIs, unsigned indices, memUsage helpers, parallel I2S handling per ESP32 variant, new limits/macros for ESP32 families.
Config and Core Flow
wled00/cfg.cpp, wled00/wled.h, wled00/wled.cpp, wled00/fcn_declare.h
deserializeConfigFromFS now returns bool; introduce useParallelI2S flag (ESP32*); globals: col→colPri, notify defaults tweaked; busConfigs becomes std::vector; add JSON helpers; WiZ data handler and deferred remote entry.
Networking/Remote
wled00/udp.cpp, wled00/remote.cpp, wled00/network.cpp
setUp→setGeometry in UDP; ESPNOW receive renamed to handleWiZdata and deferred processing via handleRemote(); add default WiFi event debug log.
JSON/Presets/Util
wled00/json.cpp, wled00/presets.cpp, wled00/util.cpp
Segment JSON uses setGeometry with 2D flags; safer apply with suspend/wait; ESP32x wait during presets; extend getVal parsing for random/inc forms.
Pins/Buttons/Hue/MQTT/XML
wled00/pin_manager.cpp, wled00/button.cpp, wled00/hue.cpp, wled00/mqtt.cpp, wled00/xml.cpp
ESP32-variant pin checks; use colPri for color ops in buttons/hue/MQTT/XML; add fillWLEDVersion; expose parallel output in LEDs settings XML.
LED State Handling
wled00/led.cpp, wled00/set.cpp
Migrate primary color to colPri across state/NL/Alexa; trigger on final brightness; set PR (parallel I2S) from settings; move to vector-based busConfigs construction.
Web UI (JS/HTML)
wled00/data/common.js, wled00/data/index.htm, wled00/data/index.js, wled00/data/settings_leds.htm, wled00/data/settings_sec.htm, wled00/data/update.htm
Pointer events for tooltips; add id to “Add palette” buttons; dynamic palette UI; color-slot handling refactor; new hardware-aware LED settings with parallel I2S option and FPS warnings; show installed version labels.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120–180 minutes

Possibly related PRs

Suggested reviewers

  • blazoncek
  • willmmiles
  • netmindz
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DedeHai DedeHai changed the base branch from main to 0_15_x September 5, 2025 17:57
@DedeHai
Copy link
Collaborator Author

DedeHai commented Sep 5, 2025

forgot to change base branch. again :)

@DedeHai DedeHai merged commit 68a8534 into wled:0_15_x Sep 7, 2025
@DedeHai DedeHai deleted the percentFX_UI_fix_015 branch September 8, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants