-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aurora Borealis effect #1589
Conversation
Moved mode_aurora function to end of FX.cpp
- Changed new palette name to have a whitespace - Undid changes to platformio.ini
I noticed I handle memory very poorly. Will need to do some rework. |
Thank you for the PR :) |
Thank you for the response :) |
Use SEGENV to allocate and manage dynamic memory needs of effect. Only allocate as much memory as needed for current amount of waves set.
Memory issues should be sorted out now ;) |
- Smoother on low speed - CRGB is trivially copiable - Replaced Red & Blue mode - Simplified logic and mem use a tiny bit - Aurora2 palette a bit less yellowish
Replaced Red & Blue effect with Aurora effect (PR #1589) Updated copyright year and contributor page link
* Added aurora effect * Cosmetic changes prior to PR to match some guidelines * Update FX.cpp Moved mode_aurora function to end of FX.cpp * Cosmetic changes prior to PR - Changed new palette name to have a whitespace - Undid changes to platformio.ini * Removed commented out test palette * Improved memory handling Use SEGENV to allocate and manage dynamic memory needs of effect. Only allocate as much memory as needed for current amount of waves set. * Improvements to Aurora effect - Smoother on low speed - CRGB is trivially copiable - Replaced Red & Blue mode - Simplified logic and mem use a tiny bit - Aurora2 palette a bit less yellowish Co-authored-by: cschwinne <dev.aircoookie@gmail.com>
Replaced Red & Blue effect with Aurora effect (PR wled#1589) Updated copyright year and contributor page link
I was so impressed with the Aurora effect that I had to look up this pull request to share a compliment. I love how this blends in so nicely when changing between color schemes. Well done @Mazn1191! |
Added an aurora borealis effect based on my Arduino project: https://github.com/Mazn1191/Arduino-Borealis
I also added a second aurora palette since the original one doesn't quite felt right.