WIP: Ethernet Support #1316
Merged
WIP: Ethernet Support #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display Ethernet IP in WiFi settings Disable welcome page if connected
tbnobody
commented
Nov 12, 2020
|
Actually I believe ETH.begin() would be fine. The WiFiEvent would just never be called. In my testing this seems to work very well, thank you! Will merge tomorrow if no further issues are reported :) |
Closed
peacepenguin
added a commit
to peacepenguin/WLED
that referenced
this pull request
Nov 13, 2020
Ethernet Support (wled#1316)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here #1027 this PR is adding support for the ethernet interface. It's maybe not yet 100% tested but ethernet is working and it still works with ESP8266 and ESP32 without ETH.