Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more need for 'seconds_exit' argument #125

Closed
2 tasks done
shikokuchuo opened this issue Sep 21, 2023 · 3 comments
Closed
2 tasks done

No more need for 'seconds_exit' argument #125

shikokuchuo opened this issue Sep 21, 2023 · 3 comments

Comments

@shikokuchuo
Copy link
Contributor

Prework

Description

As the argument 'exitlinger' has been retired at mirai as of version 0.10.0.9005 with the issue resolved shikokuchuo/mirai#63 (comment).

@shikokuchuo
Copy link
Contributor Author

FYI for the package to build on r-universe I think you just need to add links to mirai and nanonext in a packages.json in an wlandau.r-universe.dev repo as per https://ropensci.org/blog/2021/06/22/setup-runiverse/#the-packagesjson-registry-file

@wlandau
Copy link
Owner

wlandau commented Sep 21, 2023

As the argument 'exitlinger' has been retired at mirai as of version 0.10.0.9005 with the issue resolved shikokuchuo/mirai#63 (comment).

Amazing! I will deprecate seconds_exit.

FYI for the package to build on r-universe I think you just need to add links to mirai and nanonext in a packages.json in an wlandau.r-universe.dev repo as per https://ropensci.org/blog/2021/06/22/setup-runiverse/#the-packagesjson-registry-file

Thanks for the tip, I will try that.

@shikokuchuo
Copy link
Contributor Author

FYI for the package to build on r-universe I think you just need to add links to mirai and nanonext in a packages.json in an wlandau.r-universe.dev repo as per https://ropensci.org/blog/2021/06/22/setup-runiverse/#the-packagesjson-registry-file

Thanks for the tip, I will try that.

I think you also need to include your own packages, or they get deleted.. :)
r-universe/wlandau@6c248d1

wlandau-lilly added a commit to wlandau/crew.cluster that referenced this issue Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants