feat: Add params support to put()/delete() transport methods#1
Merged
Conversation
Enable query parameter passing on PUT and DELETE requests, and return response body from DELETE (previously returned None). This unblocks AppDB client methods that need params on PUT (set_permission) and DELETE with response body (bulk_delete). Changes are backward-compatible — new params arg defaults to None. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paramsargument toput()anddelete()on both sync and async transportsdelete()return type fromNonetoAny— returns response JSON body when present_updateand_deletebase class helpers to forward paramsparamsarg defaults toNoneUnblocks AppDB client which needs
paramson PUT and DELETE with response body.Testing
🤖 Generated with Claude Code