Skip to content
This repository was archived by the owner on Mar 16, 2019. It is now read-only.

My proposed 0.10.9 changes #489

Merged
merged 46 commits into from
Aug 31, 2017
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
0dd09a4
Fix path argument in iOS excludeFromBackupKey (#473)
grylance Aug 9, 2017
57af353
Fix link to fs.readStream() and to fs.writeStream() and insert link t…
lll000111 Aug 10, 2017
3a31e35
Fix the documentation part of https://github.com/wkh237/react-native-…
lll000111 Aug 10, 2017
23ef0f7
More fixes for issue https://github.com/wkh237/react-native-fetch-blo…
lll000111 Aug 11, 2017
647e88f
Fix one issue raised in https://github.com/wkh237/react-native-fetch-…
lll000111 Aug 12, 2017
05d6e03
fix some access rights, remove unused items
lll000111 Aug 14, 2017
3952293
update gradle version setting in build.gradle
lll000111 Aug 14, 2017
4c7bc55
Revert gradle settings to previous values :-(
lll000111 Aug 14, 2017
d22bdc6
add a missing closing ")"
lll000111 Aug 14, 2017
0fea62a
Removed the part of an obsolete callback function parameter that I ha…
lll000111 Aug 14, 2017
a2f13b1
let mkdir resolve with "undefined" instead of "null" (my mistake)
lll000111 Aug 14, 2017
d3e47cd
mkdir: normalize iOS and Android error if something already exists (f…
lll000111 Aug 14, 2017
2a4b11b
fix a long/int issue
lll000111 Aug 14, 2017
2233980
my mistake - according to https://facebook.github.io/react-native/doc…
lll000111 Aug 14, 2017
34e2377
Adde "utf8" as default encoding for fs.readFile - fixes #450 and #484
lll000111 Aug 15, 2017
a530f52
follow my IDEA IDE's recommendations - SparseArray instead of HashMap…
lll000111 Aug 15, 2017
7588f82
polyfill/File.js: add a parameter===undefined? check (this happened s…
lll000111 Aug 15, 2017
9682c2c
make var static again
lll000111 Aug 15, 2017
0f371ac
Normalized errors for fs.ls()
lll000111 Aug 15, 2017
0bac254
forgot one parameter
lll000111 Aug 15, 2017
30af8e9
more parameter checks
lll000111 Aug 15, 2017
c2e1d63
forgot to resolve the promise
lll000111 Aug 15, 2017
51d7453
Forgot ;
lll000111 Aug 15, 2017
4674692
add more error parameter checks
lll000111 Aug 15, 2017
3bb3bf1
change readStream()/writeStream() default encoding to utf8 to match t…
lll000111 Aug 16, 2017
45dd56c
default encoding is set in fs.js (now), no need to do it twice
lll000111 Aug 16, 2017
c2803a1
fs.js: forgot one more error refactoring
bcpclone Aug 3, 2017
a9cb606
ReadStream error events: Set a default error code "EUNSPECIFIED" if n…
lll000111 Aug 17, 2017
1080fae
writeFile() Android and iOS: improve errors; ReadStream: Add "ENOENT"…
lll000111 Aug 17, 2017
36195ca
oops - one "}" too many - removed
lll000111 Aug 17, 2017
9cde86a
add EISDIR error to readFile()s error vocabulary (iOS and Android)
lll000111 Aug 17, 2017
54afd01
"or directory" is misplaced in a "no such file" error message for rea…
lll000111 Aug 17, 2017
ea6e4d9
Android: two reject() calls did not have a code, iOS: slice() did not…
lll000111 Aug 17, 2017
9d64f5b
writeStream: return ENOENT, EISDIR and EUNSPECIFIED according to the …
lll000111 Aug 17, 2017
3394cd1
"+ +" was one plus sign too many
lll000111 Aug 17, 2017
354dc48
this if has a whole block (that ois why I prefer a style where {} are…
lll000111 Aug 17, 2017
ef9745d
I renamed this variable
lll000111 Aug 17, 2017
3292b38
1) #491 "writeStream() does not create file if it doesn't exist?"
lll000111 Aug 17, 2017
131dab2
Java: getParentFolder() may return null - prevent a NullPointerExcept…
lll000111 Aug 17, 2017
e74c944
Relating to #298 -- looping through an array is not supposed to be do…
lll000111 Aug 21, 2017
39abada
Merge branch '0.10.9' of github.com:lll000111/react-native-fetch-blob…
wkh237 Aug 27, 2017
dbafc98
Fix IOS syntax errors in #489
wkh237 Aug 27, 2017
0b90448
#489 Fix typo and missing return statement
wkh237 Aug 31, 2017
9dc2506
fix error code
wkh237 Aug 31, 2017
f00fafb
Merge branch '0.10.9' into 0.10.9
lll000111 Aug 31, 2017
c93e97e
Merge branch 'review-489' of https://github.com/wkh237/react-native-f…
lll000111 Aug 31, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix error code
  • Loading branch information
wkh237 committed Aug 31, 2017
commit 9dc25068c091e19efd1a95fe0475e90e01cfdf37
2 changes: 1 addition & 1 deletion ios/RNFetchBlobFS.m
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ + (void) writeFile:(NSString *)path
if(!exists) {
[fm createDirectoryAtPath:folder withIntermediateDirectories:YES attributes:NULL error:&err];
if(err != nil) {
return reject(@"ENODIR", [NSString stringWithFormat:@"Failed to create parent directory of '%@'; error: %@", path, [err description]], nil);
return reject(@"ENOTDIR", [NSString stringWithFormat:@"Failed to create parent directory of '%@'; error: %@", path, [err description]], nil);
}
if(![fm createFileAtPath:path contents:nil attributes:nil]) {
return reject(@"ENOENT", [NSString stringWithFormat:@"File '%@' does not exist and could not be created", path], nil);
Expand Down