Add okhttp3 to build.gradle #238
Conversation
Fixed typing errors
Code wouldn't work with those lines in there. They were meant to be comments.
|
Just a note: I messed up my git branching a bit; the 'fix readme' and 'commented out header lines' commits are not mine. If this causes any problems, let me know and I'll redo the pull request. |
|
Can this PR be merged please? Using master from react-native fails with this error. |
src/android/build.gradle
Outdated
|
|
||
| dependencies { | ||
| compile 'com.facebook.react:react-native:+' | ||
| compile 'com.squareup.okhttp3:okhttp:3.4.1' |
There was a problem hiding this comment.
There's a React Native PR to upgrade okhttp to 3.6.0 (or possibly 3.7.0). If and when that one is merged in, the version should change here as well.
|
I second the request. The referenced ticket has been closed, and I had to do the same thing when I started working on the Android sources. I still get quite a few other errors in Android Studio (https://gist.github.com/lll000111/423b858d707daf5eba5212ca5e1f6baa), which makes me wonder what else is needed to setup the Android development environment... no problems running a project, but the dev. environment is messed up. |
|
Would like to see this merged as it could fix a lot of issues regarding missing imports. |
petterh
force-pushed
the
add-okhttp3-to-build.gradle
branch
from
7eb1ff9 to
71fd9f5
Compare
|
FYI react-native-fetch-blob has a new maintained location. Check out the README. Please consider submitting your PR there, this repository is unmaintained. |
6 participants
Thank you for making a pull request ! Just a gentle reminder :)