-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Rephrase "Polygons" as "Shapes" where suitable #1484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c19fb57
to
815f433
Compare
I agree "Polygons" is no longer suitable. Maybe "Annotation" can be an option? |
The term "shape" is used internally in the code, though. I think it's alright? |
right. let's stick with "Shapes" for now, and come back when needed. |
Done (by hand). Are there instructions somewhere on how to regenerate those translation files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates user-facing text in the labelme application to use more generic terminology, changing "Polygons" to "Shapes" where appropriate. This improves the user experience by accurately reflecting that the duplicate, delete, copy, paste, hide, show, and toggle operations work on all shape types, not just polygons.
Key changes:
- Updated action labels and tooltips to use "Shapes" instead of "Polygons"
- Modified confirmation dialog messages to reference "shapes" rather than "polygons"
- Updated translation source strings in both English template and Chinese translation files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
labelme/app.py | Updated action labels, tooltips, and dialog messages from "Polygons" to "Shapes" |
labelme/translate/empty.ts | Updated English translation template with new "Shapes" terminology |
labelme/translate/zh_CN.ts | Updated Chinese translation source strings to use "Shapes" terminology |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Actually I too forgot how to do since long from last time. I'll make CI so we don't.
|
just merged #1636. can you please reset the change on the translation files? |
Re-ran |
Duplicate/Delete/... will work on not-polygon shapes
I can do that, but according to e.g. Google Translate, 编辑多边形 means "Edit Polygon" in Chinese, not "Edit Shape", so if I do that, then the Chinese translation would be mistranslated from the (new) original. |
Either is fine. If you gonna do translation by yourself, I personally trust DeepL more. |
Duplicate/Delete/... will work on not-polygon shapes, so it's a bit strange that the actions talk about Polygons only.