Skip to content

Conversation

akx
Copy link
Contributor

@akx akx commented Aug 13, 2024

  • Don't leak features in loop
    • The features were ANDed in to features in the loop, so configuring things to false might not have had an effect
  • Don't crash if configuration is missing
  • Don't use stringly typed getattr magic

* Don't leak `features` in loop
* Don't crash if configuration is missing
@akx akx force-pushed the dock-features-bug branch from 8a819ac to db6a334 Compare September 22, 2025 15:38
@akx
Copy link
Contributor Author

akx commented Sep 22, 2025

Rebased, @wkentaro 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant