Allow holding shift to delete polys without confirmation #1481
Conversation
|
@wkentaro Rebased. |
akx
force-pushed
the
deletor
branch
2 times, most recently
from
66a787c to
9c47d6c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
| if QtWidgets.QApplication.keyboardModifiers() == ( | ||
| Qt.ControlModifier | Qt.ShiftModifier | ||
| ): | ||
| if shift_and_ctrl_pressed(): |
There was a problem hiding this comment.
No - just using the same new function for the same functionality.
There was a problem hiding this comment.
i mean, this pr is for deleting poly right? why you change keep_prev?
There was a problem hiding this comment.
It was a bit of a side effect – I think, back last year when I originally made this PR, I figured it'd be worth it to unify the modifier key functionality used both for "hold shift to delete polys" and "hold shift+ctrl" as used here, into canonical helper functions.
| "{} {}".format( | ||
| self.tr("Delete the selected polygons"), | ||
| self.tr("(Hold Shift to skip confirmation)"), | ||
| ), |
There was a problem hiding this comment.
why separate translation texts?
There was a problem hiding this comment.
Because I didn't want to invalidate existing translations.
There was a problem hiding this comment.
i know, but is that the right thing to do?
There was a problem hiding this comment.
Up to you. I'm fine doing it either this way or by changing the entire translation.
akx
force-pushed
the
deletor
branch
2 times, most recently
from
f0fde03 to
98ca192
Compare
2 participants
Like it says on the tin – if Shift is pressed, skip the confirmation popup for deleting polys.