Ensure file exist before checking segment #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, attempt to fix #59.
Context: First thing, the link which generate the error is
/products/desktop/11/release-notes/#low-quality
~ l.3032 from @miltador.Process:
htmltest
will enter to the methodcheckInternalHash
then torefDoc, _ := hT.documentStore.ResolveRef(ref)
which returnnil, false
because there is no match (methodfunc (dS *DocumentStore) ResolvePath(refPath string) (*Document, bool)
), but methods are called from the struct and one of them try to acces to one of these properties as the mutex, and panic.Fix: To prevent this error I suggest to check segment only if the file exist
note: naming
segment
would be not better thanhash
incheckInternalHash
?