Check meta refresh tags #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split generic ref checking from checkGeneric, make hT.checkGenericRef function. Create check-meta.go, hT.checkMeta function. This checks meta tags. Forward meta tags to this function when scanning through NodesOfInterest. If a meta tag has http-equiv == "refresh" we check several things now: - Is the content attr present and non-blank - Is the first term in the content attr a positive integer - Is the separator ;url= - Is what follows ;url= a valid reference
Adds options CheckMeta, CheckGeneric and CheckMetaRefresh.
Current coverage is 94.47% (diff: 100%)@@ master #24 diff @@
==========================================
Files 15 16 +1
Lines 786 833 +47
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 740 787 +47
Misses 33 33
Partials 13 13
|
|
Travis OSX builds are broken currently, ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
metatags to NodesOfInterest.Split generic ref checking from checkGeneric, make hT.checkGenericRef function.
Create check-meta.go, hT.checkMeta function. This checks meta tags.
Forward meta tags to this function when scanning through NodesOfInterest.
If a meta tag has
http-equiv == "refresh"we check several things now:;url=;url= a valid referenceAdd options
CheckMeta,CheckGenericandCheckMetaRefresh.Will close #20 and sets us up for opengraph checks, re #7.