-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the NO_COLOR environment variable if it is set. #154
Conversation
If set, this will turn off colourization of the output. See https://no-color.org/ Fixes #90
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 83.27% 82.45% -0.83%
==========================================
Files 20 20
Lines 1160 1060 -100
==========================================
- Hits 966 874 -92
+ Misses 174 166 -8
Partials 20 20
Continue to review full report at Codecov.
|
I have no idea how to write test coverage for this change. If you need something, please let me know what you'd like done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers! Don't worry about tests for this, standard suite doesn't cover the main.go
file yet.
Thanks for the great tool! I've just realized I forgot to add info about this to the README. Would you like me to do so? Would it also make sense to add a |
Thanks for the contribution! Change to README and config option would be welcome. For config option name I'd go for |
Thinking about it am now unsure on want for config option as well because:
|
OK - sounds good. I'll update the README. |
If set, this will turn off colourization of the output.
See https://no-color.org/
Fixes #90