Skip to content

add @react-native-community/datetimepicker specific Props for DateTimePicker #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2020
Merged

Conversation

Macrow
Copy link
Contributor

@Macrow Macrow commented Jan 31, 2020

add @react-native-community/datetimepicker specific Props for DateTimePicker

@Macrow Macrow requested a review from Inbal-Tish February 1, 2020 05:32
@@ -177,6 +193,10 @@ class DateTimePicker extends BaseComponent {
onChange={this.handleChange}
minimumDate={minimumDate}
maximumDate={maximumDate}
locale={locale}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass {...others} instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't be better

@ethanshar ethanshar removed the request for review from Inbal-Tish February 2, 2020 06:47
@ethanshar ethanshar self-assigned this Feb 2, 2020
Co-Authored-By: Ethan Sharabi <ethans@wix.com>
@ethanshar ethanshar merged commit 1d9f017 into wix:master Feb 2, 2020
@ethanshar
Copy link
Collaborator

@Macrow
Your original PR was actually fine, I merged and fix that last change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants