Skip to content

Allow passing counter style to adjust margins of carousel component #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow passing counter style to adjust margins of carousel component #3833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ded578
allow passing counter style to adjust margins
alwaysintune Nov 5, 2025
f5a224d
Update src/components/carousel/index.tsx
alwaysintune Nov 10, 2025
ac76326
Update src/components/carousel/index.tsx
alwaysintune Nov 10, 2025
1532fdd
Update src/components/carousel/types.ts
alwaysintune Nov 10, 2025
c0c1102
remove duplicate comment
alwaysintune Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/carousel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,13 +459,13 @@ class Carousel extends Component<CarouselProps, CarouselState> {
}

renderCounter() {
const {pageWidth, showCounter, counterTextStyle} = this.props;
const {pageWidth, showCounter, counterContainerStyle, counterTextStyle} = this.props;
const {currentStandingPage} = this.state;
const pagesCount = presenter.getChildrenLength(this.props);

if (showCounter && !pageWidth) {
return (
<View center style={styles.counter}>
<View center style={[styles.counter, counterContainerStyle]}>
<Text grey80 text90 style={[{fontWeight: 'bold'}, counterTextStyle]}>
{currentStandingPage + 1}/{pagesCount}
</Text>
Expand Down
4 changes: 4 additions & 0 deletions src/components/carousel/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ export interface CarouselProps extends ScrollViewProps {
* whether to show a page counter (will not work with 'pageWidth' prop)
*/
showCounter?: boolean;
/**
* the counter's container style
*/
counterContainerStyle?: StyleProp<ViewStyle>;
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alwaysintune @adids1221
Generally, we should avoid adding styles for each view in the hierarchy.
Let's try to find a solution that solves the issue without an additional prop.
Please open a ticket if needed.

Copy link
Contributor Author

@alwaysintune alwaysintune Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only solution to add margin to the right

Copy link
Contributor Author

@alwaysintune alwaysintune Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To elaborate more - currently counter has an absolute position. Absolute position forces item design to conform, fill the full width, whilst carousel is written with use cases in mind, so a lot of props can't be used together (i. e. loop and item spacings).

Copy link
Contributor Author

@alwaysintune alwaysintune Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixing with banners leads to cases where it would be best to have a different position for counter because it conflicts with dismiss x action

/**
* the counter's text style
*/
Expand Down