Skip to content

Fix issue with missing ellipsis #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix issue with missing ellipsis #3682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a05993e
Fix issue with missing ellipsis
ethanshar Apr 9, 2025
264bf6b
Fix TextField snapshot test
ethanshar Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions demo/src/screens/__tests__/__snapshots__/TextFieldScreen.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -655,7 +655,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -1196,7 +1196,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#D2D6D8",
Expand Down Expand Up @@ -1562,7 +1562,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -1793,7 +1793,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -2158,7 +2158,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -2473,7 +2473,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -3039,7 +3039,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -3383,7 +3383,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -3818,7 +3818,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -4248,7 +4248,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -4575,7 +4575,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -4882,7 +4882,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -5203,7 +5203,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -5942,7 +5942,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -6242,7 +6242,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -6571,7 +6571,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -6946,7 +6946,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -7226,7 +7226,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -7481,7 +7481,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down Expand Up @@ -7752,7 +7752,7 @@ exports[`TextField Screen renders screen 1`] = `
"flexGrow": 1,
"paddingBottom": 0,
"paddingTop": 0,
"textAlign": "left",
"textAlign": undefined,
},
{
"color": "#20303C",
Expand Down
2 changes: 1 addition & 1 deletion src/components/textField/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const Input = ({
const styles = StyleSheet.create({
input: {
flexGrow: 1,
textAlign: Constants.isRTL ? 'right' : 'left',
textAlign: Constants.isRTL ? 'right' : undefined,
// Setting paddingTop/Bottom separately fix height issues on iOS with multiline
paddingTop: 0,
paddingBottom: 0,
Expand Down