Skip to content

Constants - add getFontScale #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 16, 2025
Merged

Constants - add getFontScale #3597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f153e1
Added fontScale to constants
nitzanyiz Mar 11, 2025
86a2ea1
Changed fontScale to a getter function
nitzanyiz Mar 11, 2025
392519a
Made fontScale regular proprety
nitzanyiz Mar 11, 2025
b842829
Made fontScale to getFontScale
nitzanyiz Mar 11, 2025
0bb4bcd
Moving usage of direct PixelRatio
nitzanyiz Mar 11, 2025
559b01d
Removed unsused import
nitzanyiz Mar 11, 2025
71c0f7f
Update src/commons/Constants.ts
nitzanyiz Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/commons/Constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import {
I18nManager,
AccessibilityInfo,
AccessibilityChangeEvent,
StatusBar
StatusBar,
PixelRatio
} from 'react-native';

export enum orientations {
Expand Down Expand Up @@ -190,7 +191,10 @@ const constants = {
},
/* Keyboard */
backspaceKey: 'Backspace',
enterKey: 'Enter'
enterKey: 'Enter',

/* Font scale */
getFontScale: PixelRatio.getFontScale
};

setStatusBarHeight();
Expand Down
4 changes: 2 additions & 2 deletions src/components/colorPicker/ColorPickerPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, {useRef} from 'react';
import {StyleSheet, TextInput, PixelRatio, I18nManager} from 'react-native';
import {StyleSheet, TextInput, I18nManager} from 'react-native';

import {Colors, Typography} from '../../style';
import {ColorPickerDialogProps} from './ColorPickerDialog';
Expand All @@ -22,7 +22,7 @@ const ColorPickerPreview = (props: PreviewProps) => {

const hex = getHexString(color);
const textColor = getTextColor(hex);
const fontScale = PixelRatio.getFontScale();
const fontScale = Constants.getFontScale();
const value = Colors.isTransparent(text) ? '000000' : text;

return (
Expand Down