ExpandableOverlay - Focus accessibility after overlay close #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanyiz
commented
Feb 13, 2025
M-i-k-e-l
reviewed
Feb 18, 2025
|
|
||
| export interface ExpandableOverlayMethods { | ||
| openExpandable: () => void; | ||
| closeExpandable: () => void; | ||
| toggleExpandable: () => void; | ||
| focusAccessibility: () => void; |
There was a problem hiding this comment.
I don't see a reason to expose focusAccessibility, it is activated on close
There was a problem hiding this comment.
I thought I might need to use it in private but we don't and forgot to remove. Removed 👌
| if (reactTag) { | ||
| AccessibilityInfo.setAccessibilityFocus(reactTag); | ||
| } | ||
| }, [containerRef]); |
There was a problem hiding this comment.
AFAIK you should not put a ref as a dependency, it won't trigger a change
Suggested change
| }, [containerRef]); | |
| }, []); |
There was a problem hiding this comment.
Mistake. Removed 👌
|
|
||
| import TouchableOpacity, {TouchableOpacityProps} from '../../components/touchableOpacity'; | ||
| import View from '../../components/view'; | ||
| import Modal, {ModalProps, ModalTopBarProps} from '../../components/modal'; | ||
| import DialogOld from '../../components/dialog'; | ||
| import DialogNew, {DialogMigrationProps} from '../dialog'; | ||
| import {Colors} from 'style'; | ||
| import {AccessibilityInfo, findNodeHandle} from 'react-native'; |
There was a problem hiding this comment.
We usually put more general imports higher up; for example I'd put react-native below react
M-i-k-e-l
approved these changes
Feb 19, 2025
M-i-k-e-l
deleted the
feat/ExpandableOverlayFocusAccessibilityAfterClose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Focused accessibility after over closes. Passed a ref to the
TouchableOpacityand set the accessibility focus on it manually when it closes.Changelog
ExpandableOverlay - Fix accessibility focus when overlay closes.
Additional info
MADS-4609