Skip to content

Feat/picker custom top element #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 19, 2025
Merged

Feat/picker custom top element #3465

merged 9 commits into from
Jan 19, 2025

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented Dec 23, 2024 •
edited
Loading

Description

Picker new RenderCustomTopElement prop.
renderCustomTopElement will render CustomTopElement above the PickerItemList.

Changelog

Picker support for new customTopElement and onItemSelection callback function.

Additional info

MADS-4575

@adids1221 adids1221 requested a review from M-i-k-e-l December 23, 2024 08:34
M-i-k-e-l
M-i-k-e-l reviewed Jan 2, 2025
View reviewed changes
@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l Jan 2, 2025
@adids1221 adids1221 requested a review from M-i-k-e-l January 9, 2025 08:26
@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 Jan 9, 2025
M-i-k-e-l
M-i-k-e-l reviewed Jan 13, 2025
View reviewed changes
@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l Jan 13, 2025
@adids1221 adids1221 requested a review from M-i-k-e-l January 13, 2025 09:49
@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 Jan 13, 2025
M-i-k-e-l
M-i-k-e-l approved these changes Jan 19, 2025
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add renderCustomTopElement to the API
Also fix the PR's description (it only adds renderCustomTopElement, name change etc)

@adids1221 adids1221 enabled auto-merge (squash) January 19, 2025 14:52
@adids1221 adids1221 merged commit ee21567 into master Jan 19, 2025
1 check passed
@adids1221 adids1221 deleted the feat/Picker_customTopElement branch January 19, 2025 14:54
@adids1221 adids1221 mentioned this pull request Feb 19, 2025
Closed
@adids1221 adids1221 mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adids1221 @M-i-k-e-l