ChipsInput - fix validation #3094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
May 28, 2024
Inbal-Tish
reviewed
May 28, 2024
src/components/chipsInput/index.tsx
Outdated
| return inputValidators.includes('required'); | ||
| }, [validate]); | ||
|
|
||
| const validateChipsInput = useCallback(() => { |
There was a problem hiding this comment.
The only validity here is 'required' but the user might pass other validations, mainly a custom validation function
There was a problem hiding this comment.
Fixed, can be tested by adding the following to the screen:
validate={['required', () => {
return this.state.chips2[0]?.label !== 'Bla';
}]}
validateOnChange
The code handling this is a little complicated, but I'm not sure it can be simplified.
Inbal-Tish
reviewed
Jun 2, 2024
Inbal-Tish
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ChipsInput - fix validation
Changelog
ChipsInput - fix validation
Additional info
None