Skip to content

Report error when failing parsing PRs #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Report error when failing parsing PRs #2842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions scripts/prReleaseNotesCommon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,21 @@ async function fetchMergedPRs(postMergedDate, repo, githubToken) {
const relevantPRs = _.flow(prs => _.filter(prs, pr => !!pr.merged_at && new Date(pr.merged_at) > postMergedDate),
prs => _.sortBy(prs, 'merged_at'),
prs =>
_.map(prs, pr => ({
state: pr.state,
merged_at: pr.merged_at,
html_url: pr.html_url,
branch: pr.head.ref,
number: pr.number,
title: pr.title,
info: parsePR(pr.body)
})))(PRs);
_.map(prs, pr => {
try {
return {
state: pr.state,
merged_at: pr.merged_at,
html_url: pr.html_url,
branch: pr.head.ref,
number: pr.number,
title: pr.title,
info: parsePR(pr.body)
};
} catch {
console.error('Failed parsing PR: ', pr.html_url);
}
}))(PRs);

return relevantPRs;
}
Expand Down Expand Up @@ -182,7 +188,13 @@ async function _generateReleaseNotes(latestVersion, newVersion, githubToken, fil
console.log(`\x1b[1m\x1b[32m✔\x1b[0m \x1b[32m${fileNamePrefix}-release-notes.txt was successfully written to ${process.env.HOME}/Downloads\x1b[0m \x1b[1m\x1b[32m✔\x1b[0m`);
}

async function generateReleaseNotes(latestVersion, newVersion, githubToken, fileNamePrefix, repo, header = '', tagPrefix = '') {
async function generateReleaseNotes(latestVersion,
newVersion,
githubToken,
fileNamePrefix,
repo,
header = '',
tagPrefix = '') {
let latestVer, newVer;
const rl = readline.createInterface({
input: process.stdin,
Expand Down