Skip to content

Mandatory Indication in placeholder #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 14, 2023
Merged

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Nov 1, 2023

Description

Added the mandatory indication to the placeholder as well so it would show if the label is not present or the textfield uses a floating placeholder.
Tests added to check behavior.

Changelog

TextField - added mandatory indication to the TextField

Additional info

WOAUILIB-3823

@nitzanyiz nitzanyiz requested a review from ethanshar November 1, 2023 13:26
@nitzanyiz nitzanyiz changed the title Adding mandatory indication to the placeholder in case a label is not given. Mandatory Indication in placeholder Nov 1, 2023
@nitzanyiz nitzanyiz marked this pull request as ready for review November 1, 2023 14:20
@ethanshar ethanshar merged commit e7ecdd2 into master Nov 14, 2023
@nitzanyiz nitzanyiz deleted the feat/mandatoryToPlaceHolder branch November 29, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants