Picker - add onItemPress #2786
Closed
Picker - add onItemPress #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
added
the
Important for Next Release
ethanshar
reviewed
Oct 31, 2023
| /** | ||
| * A callback to be used when an item has been pressed, will stop selection if false is returned | ||
| */ | ||
| onItemPress?: (item: PickerValue) => Promise<boolean>; |
There was a problem hiding this comment.
assuming people dont need onItemPress to be asynchronous, typing wise they will still need to return a promise and that can be annoying, no?
if my logic is synchronous, TS won't complain?
| const onDoneSelecting = useCallback((item: PickerValue) => { | ||
| const onDoneSelecting = useCallback(async (item: PickerValue) => { | ||
| // Using !(await onItemPress?.(item)) does not work properly when onItemPress is not sent | ||
| if (onItemPress && !(await onItemPress(item))) { |
There was a problem hiding this comment.
We already have an onPress callback in PickerItemProps, do you think we should use that?
There was a problem hiding this comment.
The other way I found to do this is shown in another PR, you choose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker - add onItemPress
Relates to the FontPicker
Changelog
Picker - add onItemPress
Additional info
None