Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel picker custom cancel button and title and container custom styling #2648

Closed
wants to merge 1 commit into from

Conversation

trofima
Copy link
Contributor

@trofima trofima commented Jun 30, 2023

Description

Wheel picker custom cancel button and title and container custom styling
Fixes the #2557

Still there is no support of custom cancel/done buttons but it was not requested in the issue anyway

@trofima trofima self-assigned this Jun 30, 2023
@trofima trofima changed the title wheel picker title and container custom styling Wheel picker custom cancel button and title and container custom styling Jun 30, 2023
@trofima trofima requested a review from ethanshar June 30, 2023 13:40
@trofima trofima linked an issue Jun 30, 2023 that may be closed by this pull request
5 tasks
@ethanshar ethanshar requested a review from lidord-wix July 5, 2023 11:08
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! please see my small comment :)

Comment on lines +139 to +140
doneLabel: 'YES',
cancelLabel: 'NO',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change to labels to something more clear, maybe Cancel and 'Done`? 😅

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 17, 2023
@stale stale bot closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No cancel button on Picker component
2 participants