-
Notifications
You must be signed in to change notification settings - Fork 735
SortableList - add driver and test #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I wrote some small comments, and:
- Why does the changelog "None"?
- Do we need to add some mocks in private or mobile-mocks? (will it potentially break something?)
- Consider creating a private version for the module to check that it answers their needs :)
Almost forgot :)
|
|
lidord-wix
approved these changes
Apr 19, 2023
I don't really see this having impact on the cycle, but ok |
lidord-wix
pushed a commit
that referenced
this pull request
May 15, 2023
* SortableList - add driver and test * Review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SortableList - add driver and test
WOAUILIB-3444
Changelog
SortableList - add driver and test