Skip to content

Omit alignment props from passing forward to Text and TextInput components #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Omit alignment props from passing forward to Text and TextInput components #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/components/text/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,17 @@ class Text extends PureComponent<PropsTypes> {
render() {
const {
// (!) extract flex prop to avoid passing them on Android
// TODO: extract alignment (top, right, ...) props till we manage to exclude them from typings
/* eslint-disable */
flex,
// @ts-ignore
left,
// @ts-ignore
top,
// @ts-ignore
right,
// @ts-ignore
bottom,
/* eslint-enable */
modifiers,
style,
Expand Down
9 changes: 9 additions & 0 deletions src/incubator/TextField/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,18 @@ const DEFAULT_INPUT_COLOR: ColorType = {

const Input = ({
// (!) extract flex prop to avoid passing them on Android
// TODO: extract alignment (top, right, ...) props till we manage to exclude them from typings
/* eslint-disable */
// @ts-ignore (does not exist on props)
flex,
// @ts-ignore
left,
// @ts-ignore
top,
// @ts-ignore
right,
// @ts-ignore
bottom,
/* eslint-enable */
style,
hint,
Expand Down