TextFiled Presenter getColorByState fix #2290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o check if the color that passed is design token
lidord-wix
reviewed
Oct 19, 2022
src/style/colors.ts
Outdated
| @@ -290,6 +293,9 @@ export class Colors { | |||
| const colorB = colorStringValue(colorBValue); | |||
| return _.toLower(colorA) === _.toLower(colorB); | |||
| } | |||
| isDesignToken(color?: DesignToken) { | |||
| return !!color?.semantic || !!color?.resource_paths; | |||
There was a problem hiding this comment.
Suggested change
| return !!color?.semantic || !!color?.resource_paths; | |
| return color?.semantic || color?.resource_paths; |
lidord-wix
approved these changes
Oct 19, 2022
adids1221
added a commit
that referenced
this pull request
Oct 20, 2022
* TextFiled Presenter getColorByState fix, new function isDesignToken to check if the color that passed is design token * Fixed review notes, added test to colors.spec file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextFiled Presenter getColorByState fix, new util function isDesignToken.
Changelog
TextFiled Presenter getColorByState fix, new util function isDesignToken.