Feat/incubator dialog more props and fixes #2251
Conversation
M-i-k-e-l
added
the
Important for Next Release
|
@M-i-k-e-l |
I understand, but each commit is a change which can be viewed individually and while they are not exactly coupled, in order to have higher confidence in the changes, I wanted to perform a few migrations (while doing other migrations later on). |
| if (onModalDismissed) { | ||
| LogService.deprecationWarn({component: 'ActionSheet', oldProp: 'onModalDismissed', newProp: 'onDismiss'}); | ||
| } |
There was a problem hiding this comment.
Today users maybe use both props for two different purposes, are we omitting the onModalDismissed prop?
There was a problem hiding this comment.
onModalDismissed comes from the ActionSheet, it is no longer needed with the new Dialog.
We cannot omit it because that will cause a TS error, I'll add deprecated to it.
There was a problem hiding this comment.
I understand, but if a user uses our ActionSheet and passes those both props, with a different callback for each (for some reason) he won't be able to do so anymore.
I agree it's a bit rare and not something that we should care about much, but at least mention somewhere that it's a breaking change.. don't you think?
There was a problem hiding this comment.
But the user does not have to send the migrateDialog prop, this will only be "mandatory" in v7, where we can break the user. If they choose to migrate, they can fix the logic they have.
Not sure if this is clear, but this is not our private ActionSheet.
Description
You can look at individual commits for simplicity.
Incubator.Dialog - add support for a few things (custom elements,
onPresson the header +widthandheightin the dialog) and a couple of fixes.Add API for DialogHeader.
Start migration in
ActionSheetand a couple of screens (and support it onIncubator.WheelPicker.Naming: I am not sure about a couple of styles names (see TODO), suggestions are welcome.
WOAUILIB-2317
WOAUILIB-3072
Changelog
Incubator.Dialog - add support for a few things, a couple of fixes and start a migration for ActionSheet.