Skip to content

Slider - new features #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 12, 2022
Merged

Slider - new features #2248

merged 9 commits into from
Sep 12, 2022

Conversation

Inbal-Tish
Copy link
Collaborator

@Inbal-Tish Inbal-Tish commented Sep 11, 2022

Description

Slider - Adding 'reset' function with callback 'onReset', initial values to range slider, 'useGap' prop.

Changelog

Slider - Adding 'reset' function with callback 'onReset', initial values to range slider, 'useGap' prop.

@Inbal-Tish Inbal-Tish changed the title Feat/slider new features Slider - new features Sep 11, 2022
@ethanshar ethanshar requested review from lidord-wix and removed request for ethanshar September 11, 2022 08:58
@ethanshar ethanshar assigned lidord-wix and unassigned ethanshar Sep 11, 2022
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I wrote some small comments

Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, please see my last comment before merging

Co-authored-by: Lidor Dafna <66782556+lidord-wix@users.noreply.github.com>
@ajp8164
Copy link

ajp8164 commented Sep 16, 2022

Thanks for this! Just getting to look at these new changes - will check against my implementation needs. Thanks for linking over my PRs.

@Inbal-Tish Inbal-Tish deleted the feat/Slider_new_features branch November 6, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants