-
Notifications
You must be signed in to change notification settings - Fork 734
Add build:local script #2245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build:local script #2245
Conversation
@M-i-k-e-l |
Done. |
.gitignore
Outdated
@@ -2,6 +2,10 @@ | |||
# | |||
.DS_Store | |||
|
|||
# Do not track local package | |||
react-native-ui-lib-5.0.0.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it always be 5.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it comes from our package.json
's version
, so it should not change since we do not really update it.
scripts/createLocalPackage.sh
Outdated
git clean -f | ||
git checkout package.json | ||
# Rename tar | ||
mv react-native-ui-lib-5.0.0.tgz react-native-ui-lib.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mv to the user Downloads folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, this should probably remove the need for the ignore, and solve the above comment.
Wrote some comment, anyway approved. |
Description
Add a script to build changes locally.
Usage:
npm run build:local
react-native-ui-lib-5.0.0.tgz
(preferably in another location).react-native-ui-lib
in yournode_modules
(probably backup or delete your currentnode_modules/react-native-ui-lib
).react-native-ui-lib-5.0.0.tgz
.package.json
will change, take extra care if you have changes there.Note: I've added a warning if the user has untracked files (which will be deleted without this).
CC @Inbal-Tish @lidord-wix @adids1221
Changelog
None