Skip to content

WIP - web demo app #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 20, 2022
Merged

WIP - web demo app #2233

merged 21 commits into from
Sep 20, 2022

Conversation

OrenZak
Copy link
Contributor

@OrenZak OrenZak commented Sep 1, 2022

Description

Create basic web support, and a demo app to showcase the support of current state.

Changelog

  • Added new package -> webDemo
  • using a snapshot version of this branch, cuz i've changed few files to be able to render on web.

@OrenZak OrenZak changed the title Oren/web support WIP - web demo app Sep 1, 2022
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OrenZak
Can you explain a little, why do we need all of the files under src/blur? It appears you created a web alternative for the blur-view library, is that right?

Another question, what's the purpose of all the components under src/webComs?

@OrenZak
Copy link
Contributor Author

OrenZak commented Sep 15, 2022

@OrenZak Can you explain a little, why do we need all of the files under src/blur? It appears you created a web alternative for the blur-view library, is that right?

Another question, what's the purpose of all the components under src/webComs?

  1. we need that because they are missing web support, and its a dependency you have. so i created this folder as a polyfill to the blur lib.

  2. webComps, are just demo components i used, so they are using the components with some data

@ethanshar
Copy link
Collaborator

@OrenZak Can you explain a little, why do we need all of the files under src/blur? It appears you created a web alternative for the blur-view library, is that right?
Another question, what's the purpose of all the components under src/webComs?

  1. we need that because they are missing web support, and its a dependency you have. so i created this folder as a polyfill to the blur lib.
  2. webComps, are just demo components i used, so they are using the components with some data

As for 1, we use the "blur" package optionally. Only in specific cases, is there a real reason to polyfill it, can't we ignore the relevant feature while on Web?
For example here, you can see we only use the blur package only when the enableBlur is passed. IMO, we can just ignore such props on Web, WDYT?

@OrenZak
Copy link
Contributor Author

OrenZak commented Sep 15, 2022

@OrenZak Can you explain a little, why do we need all of the files under src/blur? It appears you created a web alternative for the blur-view library, is that right?
Another question, what's the purpose of all the components under src/webComs?

  1. we need that because they are missing web support, and its a dependency you have. so i created this folder as a polyfill to the blur lib.
  2. webComps, are just demo components i used, so they are using the components with some data

As for 1, we use the "blur" package optionally. Only in specific cases, is there a real reason to polyfill it, can't we ignore the relevant feature while on Web? For example here, you can see we only use the blur package only when the enableBlur is passed. IMO, we can just ignore such props on Web, WDYT?

i think that we will need to support blur for web.
we can ignore for now i guess.

@ethanshar
Copy link
Collaborator

ethanshar commented Sep 18, 2022

i think that we will need to support blur for web. we can ignore for now i guess.

Let's ignore it and remove its code. I don't want to maintain a web implementation for another library

@ethanshar
Copy link
Collaborator

i think that we will need to support blur for web. we can ignore for now i guess.

Let's ignore it and remove its code. I don't want to maintain a web implementation for another library

@OrenZak Are you planning to handle this one?

@OrenZak
Copy link
Contributor Author

OrenZak commented Sep 20, 2022

i think that we will need to support blur for web. we can ignore for now i guess.

Let's ignore it and remove its code. I don't want to maintain a web implementation for another library

@OrenZak Are you planning to handle this one?

yes, will do.

@ethanshar ethanshar enabled auto-merge (squash) September 20, 2022 12:27
@ethanshar ethanshar merged commit 4a40557 into master Sep 20, 2022
@OrenZak OrenZak deleted the oren/web_support branch September 20, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants