Skip to content

Avoid redundant setState in TouchableOpacity #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Avoid redundant setState in TouchableOpacity #2177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Avoid redundant setState in TouchableOpacity
  • Loading branch information
@ethanshar
ethanshar committed Aug 9, 2022
commit 0cda402869b9a95075fde8c0b19fbd74d57b365b
8 changes: 6 additions & 2 deletions src/components/touchableOpacity/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,17 @@ class TouchableOpacity extends PureComponent<Props, {active: boolean}> {
}

onPressIn = (...args: any) => {
this.setState({active: true});
if (this.props.activeBackgroundColor) {
this.setState({active: true});
}
//@ts-expect-error
this.props.onPressIn?.(...args);
};

onPressOut = (...args: any) => {
this.setState({active: false});
if (this.props.activeBackgroundColor) {
this.setState({active: false});
}
//@ts-expect-error
this.props.onPressOut?.(...args);
};
Expand Down