Split the renderRibbon to 2 render functions changed the logic #2173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Aug 9, 2022
src/components/avatar/index.tsx
Outdated
| @@ -384,7 +389,8 @@ class Avatar extends PureComponent<AvatarProps> { | |||
| </View> | |||
| {this.renderImage()} | |||
| {this.renderBadge()} | |||
| {this.renderRibbon()} | |||
| {hasCustomRibbon && this.renderCustomRibbon()} | |||
| {!hasCustomRibbon && hasRibbonLabel && this.renderRibbon()} | |||
There was a problem hiding this comment.
I'd remove here only the condition of !hasCustomRibbon
Basically it means it will move the responsibility to the user.
If the user pass both ribbonLabel and customRibbon they will have a UI bug and it should be their responsibility to handle it.
ethanshar
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed customRibbon props render in Avatar component
Changelog
Fixed customRibbon props render in Avatar component