Infra/animated image improvements #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effanuel
reviewed
Aug 1, 2022
| import View from '../../components/view'; | ||
| import Image, {ImageProps} from '../../components/image'; | ||
|
|
||
| const UIAnimatedImage = Animated.createAnimatedComponent<ImageProps>(Image); |
There was a problem hiding this comment.
Is calling this method expensive?
There was a problem hiding this comment.
Anyone importing a type from this file, and not using import type will call this method
There was a problem hiding this comment.
I do not know, but this is a semi-common usage (from what I've seen in another lib this was a HOC).
I think this is only called once for the whole app, am I wrong? So unless you mean that a public user might accidentally do that, it does not matter.
lidord-wix
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AnimatedImage:
entering).loader.Avatar- WOAUILIB-2913).Note: this unfortunately may remove the history from this file, an option is to change to a tsx (while breaking master's
npm run build:dev) and only then merging this.Changelog
AnimatedImage - fix functionality and improve performance