Infra/ colorSwatch perf improvements #2154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effanuel
reviewed
Jul 28, 2022
| @@ -148,7 +149,7 @@ class ColorSwatch extends PureComponent<Props> { | |||
| onPress={this.onPress} | |||
| style={[this.styles.container, style]} | |||
| onLayout={this.onLayout} | |||
| {...this.getAccessibilityInfo()} | |||
| {...accessibilityInfo} | |||
There was a problem hiding this comment.
Why is the previous approach slow?
There was a problem hiding this comment.
We added a condition to get the accessibility info only when the user is on accessibility mode since the calculation we do for getting the color name is pretty heavy.
Merged
ethanshar
added
the
Important for Next Release
Inbal-Tish
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
accessibilityInfoonly if the accessibility mode is onimproves performance by ~71%
Changelog
ColorSwatch - add
accessibilityInfoonly if the accessibility mode is on