Fix/thumbnail resize android #2150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
the
Important for Next Release
ethanshar
requested changes
Jul 31, 2022
ethanshar
requested changes
Aug 1, 2022
src/components/image/index.tsx
Outdated
| @@ -206,7 +206,7 @@ class Image extends PureComponent<Props, State> { | |||
| const shouldFlipRTL = supportRTL && Constants.isRTL; | |||
| const ImageView = this.shouldUseImageBackground() ? ImageBackground : RNImage; | |||
| const {margins} = modifiers; | |||
| // const resizeMode = useImageInsideContainer ? 'contain' : undefined; | |||
| console.log(`useImageInsideContainer: ${useImageInsideContainer}`); | |||
There was a problem hiding this comment.
Don't keep console.log in the code
ethanshar
approved these changes
Aug 1, 2022
ethanshar
pushed a commit
that referenced
this pull request
Aug 1, 2022
* Fixed thumbnail resize bug on android, the bug was in image component * Prettier eslint code format * Update snapshot * Fixed reviwe notes * Fixed review notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed image resize mode bug on android , WOAUILIB-2865
Changelog
Fixed image resize mode bug on android