DO NOT MERGE - Use the new activateAfterLongPress to fix an Android bug #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Jul 5, 2022
ethanshar
approved these changes
Jul 13, 2022
ethanshar
added a commit
that referenced
this pull request
Jul 13, 2022
…ug (#2110) * Use the new activateAfterLongPress to fix an Android bug * Set peer react-native-gesture-handler to 2.5.0 Co-authored-by: Ethan Sharabi <ethans@wix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
We need to HF after engine is released with the new version.
But we should mention the new requirement in the public release
Description
Use the new react-native-gesture-handler activateAfterLongPress to fix (old?) Android not working (drag is not working or sometimes not working).
I've deleted the external hook which is no longer needed.
WOAUILIB-2756
Changelog
Use the new react-native-gesture-handler activateAfterLongPress to fix drag not always working on Android - REQUIRES VERSION 2.5.0 of react-native-gesture-handler