Support useWheelPicker in Picker component #2100
Conversation
| @@ -137,7 +137,8 @@ export default class PickerScreen extends Component { | |||
| <Picker | |||
| title="Native Picker" | |||
There was a problem hiding this comment.
Change the title too. Also, don't you want to keep both examples for native and wheel pickers?
There was a problem hiding this comment.
Well, I want to deprecate useNativePicker, you mean for the sake of sanity checks - to see nothing was broken with useNativePicker prop?
There was a problem hiding this comment.
Sure, if you're deprecating the 'useNativePicker' now there's no point having its example (but the title should be changed to avoid confusion).
src/components/picker/index.tsx
Outdated
| @@ -190,6 +197,8 @@ const Picker = (props: PropsWithChildren<PickerProps> & ForwardRefInjectedProps | |||
| return ( | |||
| <PickerItemsList | |||
| testID={`${testID}.modal`} | |||
| useWheelPicker={useWheelPicker} | |||
| items={items} | |||
There was a problem hiding this comment.
Shouldn't you pass 'items' only if 'useWheelPicker' is true?
There was a problem hiding this comment.
I can add a condition, but it doesn't really matter or affect the code.
There was a problem hiding this comment.
I think it's better to secure no side-effects
Description
Support useWheelPicker in Picker component
This should replace useNativePicker implementation
Changelog
Support useWheelPicker prop in Picker component in order to render a wheel picker component