Skip to content

Support Picker field types #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 9, 2022
Merged

Support Picker field types #2054

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
928f346
Support Picker field types
ethanshar May 18, 2022
4c64a31
Export PickerFieldTypes
ethanshar May 19, 2022
7692d05
Prioritize users props over fieldType props
ethanshar May 19, 2022
ad2bf91
Fix override of props by field types
ethanshar May 19, 2022
ebe73ee
Merge branch 'master' into feat/Picker_fieldTypes
ethanshar Jun 8, 2022
274e8ef
Add description to new fieldType prop
ethanshar Jun 8, 2022
ae24d55
Add fieldType prop to documentation
ethanshar Jun 8, 2022
c723e05
Set default color of our Text component to be $textDefault
ethanshar Jun 8, 2022
c4dbbad
Fix spacing for dropdown icon
ethanshar Jun 8, 2022
b4bd27c
Revert Text default color change
ethanshar Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix spacing for dropdown icon
  • Loading branch information
@ethanshar
ethanshar committed Jun 8, 2022
commit c4dbbad9bf6fb6b765499a6cefdae3746584f7f7
2 changes: 1 addition & 1 deletion src/components/picker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ const Picker = (props: PropsWithChildren<PickerProps> & ForwardRefInjectedProps
return {
preset: preset || null,
containerStyle: {flexDirection: 'row'},
trailingAccessory: <Icon source={dropdown}/>
trailingAccessory: <Icon marginL-s1 source={dropdown}/>
};
} else if (fieldType === PickerFieldTypes.settings) {
return {
Expand Down