Use Gesture to handle TabBarItem presses #2039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
May 11, 2022
| }, [style]); | ||
|
|
||
| const gesture = Gesture.Tap() | ||
| .maxDuration(60000) |
There was a problem hiding this comment.
Is this limit solving a problem?
There was a problem hiding this comment.
Yes, it create a proper time between touch down and touch up.
I didnt find any proper way to do it.
I need to handle touch down - for the active press background color and opacity
and touch up - is for completing the actual press (and moving the current index)
There was a problem hiding this comment.
Oh, I just tested without it and with .maxDuration(0) and now I get it.
I'd expect it'll be possible to have unlimited time...
M-i-k-e-l
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small improvement for performance in TabController component.
In TabBarItem I replaced the
TouchableOpacitywith gesture-handlerGesturecomponent.Instead of having a round trip (Native side -> JS side) to invoke the
onPresscallback in order to change thecurrIndexshared value, I now use the Gesture API to do that, this way we avoid the round trip.Changelog
Small performance improvement in TabController transitions