Skip to content

Fix/ radioButton alignments #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 24, 2022
Merged

Fix/ radioButton alignments #1999

merged 9 commits into from
Apr 24, 2022

Conversation

lidord-wix
Copy link
Contributor

Description

Fix alignments for RadioButton with contentOnLeft
WOAUILIB-2661
Start deprecation of contentOnRight prop

Changelog

Fix alignments for RadioButton and add contentOnLeft prop

@lidord-wix lidord-wix requested a review from ethanshar April 19, 2022 10:56
@lidord-wix lidord-wix requested a review from M-i-k-e-l April 24, 2022 08:32
@lidord-wix lidord-wix assigned M-i-k-e-l and unassigned ethanshar Apr 24, 2022
@lidord-wix lidord-wix removed the request for review from ethanshar April 24, 2022 08:33
@lidord-wix lidord-wix added the Important for Next Release PR that must be included in the release version label Apr 24, 2022
@M-i-k-e-l M-i-k-e-l enabled auto-merge (squash) April 24, 2022 09:39
M-i-k-e-l and others added 5 commits April 24, 2022 12:44
@M-i-k-e-l @lidord-wix
Fix/skeleton types (#1998)
7380477 
* Skeleton related types fixes

* Prettify

* Add relevant modifiers to SkeletonViewProps

* Revert default type
@ethanshar @lidord-wix
Enable useNative when passing activeScale and add its type (#1997)
2ade966 
* Enable useNative when passing activeScale and add its type

* Fix check on activeScale
@M-i-k-e-l @Inbal-Tish @lidord-wix
Keyboard components - add docs (#1984)
0adfc05 
* Keyboard components - add docs

* Damn you copy-paste

* Fix typo

Co-authored-by: Inbal Tish <33805983+Inbal-Tish@users.noreply.github.com>

* Fix names

Co-authored-by: Inbal Tish <33805983+Inbal-Tish@users.noreply.github.com>
@avishain @lidord-wix
not enable scroll if content is less than 1 pixel than it container (#…
c555fd3 
…1972)

* disable scroll for less than 1 pixel

should prevent situations where a friction of pixel enables scroll and hence causes the scrollview-fader appear with no reason

* change methodology to use Math.floor
@lidord-wix
Merge branch 'master' into fix/radioButton-alignments
6e08756
@M-i-k-e-l M-i-k-e-l merged commit 3a6bb2f into master Apr 24, 2022
@lidord-wix lidord-wix deleted the fix/radioButton-alignments branch May 2, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidord-wix @M-i-k-e-l @ethanshar @avishain