Support using PlatformColor for designTokens #1939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added support for reading native colors using RN PlatfomColor API for loaded design tokens.
This will only work when the user purposely enable this feature by calling
Colors.enabledPlatformColors
The reason for that is that the users must load the relevant colors in their native code.
For now, this will be false in the public code.
We will enable this and load the platform colors in native only in private for now.
Unfortunately, PlatformColor API is not so flexible, for instance I can't try/catch it and return the original JS color, like this
Changelog
Support using RN PlatformColor API for loaded design tokens