Carousel - render tests - first tests #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidord-wix
reviewed
Nov 30, 2021
lidord-wix
reviewed
Dec 1, 2021
src/components/carousel/index.tsx
Outdated
| animated={animated} | ||
| style={[{marginBottom}, containerStyle]} | ||
| onLayout={this.onContainerLayout} | ||
| testID={testID} |
There was a problem hiding this comment.
As we talked about in the meeting, we usually pass the testID to the main component and not to the wrapping view. consider passing the testID directly to the scrollView.
There was a problem hiding this comment.
If I'll do that I won't be able to test anything on the container. I don't think it's the right call in this case...
There was a problem hiding this comment.
What do you want to test on the container? I saw you don't have any test for it at the moment..
There was a problem hiding this comment.
You know what? Since {...others} is passed to the ScrollView, I'll leave the testID there so I won't break anyone. Thanks
…a/Carousel_component_tests
…a/Carousel_component_tests
lidord-wix
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Carousel - render tests - first tests.
Changelog
Carousel - render tests - first tests.