chipsInput add onFocus callback #1667
Conversation
src/components/chipsInput/index.tsx
Outdated
| @@ -298,6 +298,7 @@ class ChipsInput extends Component<OwnProps, State> { | |||
| } | |||
|
|
|||
| onFocus = () => { | |||
| _.invoke(this.props, 'onFocus'); | |||
There was a problem hiding this comment.
Please use optional chaining and pass the event (i.e. e: NativeSyntheticEvent)
There was a problem hiding this comment.
If you can do the same for 'onBlur' that will be much appreciated!
There was a problem hiding this comment.
I can't use optional chaining, because onKeyPress above is using lodash invoke.
There was a problem hiding this comment.
The type should be NativeSyntheticEvent<TextInputFocusEventData> otherwise it fails on TS error
|
@vidmantas0010 Merge master to your branch (will fix failed build) |
|
@vidmantas0010 Pull master again, we had tests failing that broke the builds |
|
Closing this. |
Description
ChipsInput add onFocus callback prop
Changelog
chipsInput