Skip to content

Fix for overflow items into menu not showing because of color #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdevocht merged 2 commits into from
Mar 9, 2026
+4 −0
Merged

Fix for overflow items into menu not showing because of color #8243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ba8ef
Fix for overflow items into menu not showing because of color
markdevocht Mar 8, 2026
9e64f42
Merge branch 'master' into bugfix/Android-Minimal-Header-Overflow-Men…
markdevocht Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/src/main/java/com/reactnativenavigation/views/stack/topbar/titlebar/ButtonBar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import android.view.View
import android.view.ViewGroup
import androidx.appcompat.widget.ActionMenuView
import androidx.appcompat.widget.Toolbar
import com.reactnativenavigation.R
import com.reactnativenavigation.utils.ObjectUtils
import com.reactnativenavigation.utils.ViewUtils
import com.reactnativenavigation.viewcontrollers.stack.topbar.button.ButtonController
Expand All @@ -21,6 +22,7 @@ open class ButtonBar internal constructor(context: Context) : Toolbar(context) {
init {
super.setContentInsetsAbsolute(0, 0)
this.contentInsetStartWithNavigation = 0
setPopupTheme(R.style.TopBarOverflowPopup)
}

override fun onViewAdded(child: View) {
Expand Down
2 changes: 2 additions & 0 deletions android/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<item name="elevation">0dp</item>
</style>

<style name="TopBarOverflowPopup" parent="ThemeOverlay.AppCompat.Light" />

<!--The following is a workaround needed to run unit tests in command line-->
<style name="Widget.Support.CoordinatorLayout" parent="android:Widget">
@null
Expand Down