-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add RN 0.84 support #8240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yedidyak
wants to merge
14
commits into
master
Choose a base branch
from
RN_84
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add RN 0.84 support #8240
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9886334
Add RN 0.84 support: bump defaults, fix version-switch script, add CI…
yedidyak d2ece36
Guard legacy imports behind arch checks for RN 0.84 compatibility
yedidyak ef00b94
Bump deps for RN 0.84 and guard remaining legacy iOS imports
yedidyak b9ffcde
Simplify: deduplicate import, cache NSClassFromString in hitTest hot …
yedidyak 7824639
Remove stale react-native-fast-image manual dep from Android build.gr…
yedidyak 27aa131
Add skill document for RN version upgrade process
yedidyak 8b7a0a0
Fix iOS test build: guard arch-specific API call in RNNViewController…
yedidyak 7d4de45
Guard remaining test files for new-arch compatibility
yedidyak ce43d35
Merge branch 'master' into RN_84
yedidyak 01763ad
Address Copilot review: NaN guard, nil sourceView check, explicit imp…
yedidyak 0785d4a
Bump CI to latest patch versions: RN 0.83.2 and 0.84.1
yedidyak 98bbe2d
Revert RN 0.84 to 0.84.0, 0.84.1 still under embargo
yedidyak 2626b5c
Relax SSIM threshold to 0.985 for cross-version rendering tolerance
yedidyak 9704a1a
Align root deps with playground: replace fast-image, bump reanimated/…
yedidyak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # TODO(2026-03-13): bump to 0.84.1 once it clears the embargo (released 2026-02-27) | ||
| - label: ":android: Android (RN 0.84.0)" | ||
| env: | ||
| JAVA_HOME: /opt/openjdk/jdk-17.0.9.jdk/Contents/Home/ | ||
| REACT_NATIVE_VERSION: 0.84.0 | ||
| command: | ||
| - "nvm install" | ||
| - "./scripts/ci.android.sh" | ||
| key: "android_rn_84" | ||
| timeout_in_minutes: 90 | ||
| artifact_paths: "/Users/builder/uibuilder/work/playground/artifacts/**/*" | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # TODO(2026-03-13): bump to 0.84.1 once it clears the embargo (released 2026-02-27) | ||
| - label: ":ios: iOS (RN 0.84.0)" | ||
| env: | ||
| REACT_NATIVE_VERSION: 0.84.0 | ||
| command: | ||
| - "nvm install" | ||
| - "./scripts/ci.ios.sh" | ||
| key: "ios_rn_84" | ||
| timeout_in_minutes: 90 | ||
| artifact_paths: "/Users/builder/uibuilder/work/playground/artifacts/**/*" | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,32 @@ | ||
| #import "RNNAppDelegate.h" | ||
| #import <ReactNativeNavigation/ReactNativeNavigation.h> | ||
| #import <react/featureflags/ReactNativeFeatureFlags.h> | ||
| #import <react/featureflags/ReactNativeFeatureFlagsDefaults.h> | ||
|
|
||
| #import "RCTAppSetupUtils.h" | ||
|
|
||
| #if !RNN_RN_VERSION_79_OR_NEWER | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also here, no need to add or change lower version support because it is already handled and working. |
||
| // Legacy path (RN < 0.79) — needs bridge, turbo module manager, feature flags | ||
| #import <React/CoreModulesPlugins.h> | ||
| #import <React/RCTBridge+Private.h> | ||
| #import <React/RCTBridgeProxy.h> | ||
| #import <React/RCTComponentViewFactory.h> | ||
| #import <React/RCTCxxBridgeDelegate.h> | ||
| #import <React/RCTImageLoader.h> | ||
| #import <React/RCTLegacyViewManagerInteropComponentView.h> | ||
| #import <React/RCTSurfacePresenter.h> | ||
| #import <React/RCTSurfacePresenterStub.h> | ||
| #import <React/RCTSurfacePresenterBridgeAdapter.h> | ||
| #import <React/RCTSurfacePresenterStub.h> | ||
| #import <ReactCommon/RCTTurboModuleManager.h> | ||
|
|
||
| #import <react/featureflags/ReactNativeFeatureFlags.h> | ||
| #import <react/featureflags/ReactNativeFeatureFlagsDefaults.h> | ||
| #if __has_include(<react/config/ReactNativeConfig.h>) | ||
| #import <react/config/ReactNativeConfig.h> | ||
| #endif | ||
|
|
||
| #import <react/renderer/runtimescheduler/RuntimeScheduler.h> | ||
| #import <react/renderer/runtimescheduler/RuntimeSchedulerCallInvoker.h> | ||
| #import <React/RCTSurfacePresenter.h> | ||
| #import <React/RCTBridge+Private.h> | ||
| #import <React/RCTImageLoader.h> | ||
| #import <React/RCTBridgeProxy.h> | ||
| #import <React/RCTSurfacePresenter.h> | ||
| #import <react/utils/ManagedObjectWrapper.h> | ||
|
|
||
| #import <React/RCTComponentViewFactory.h> | ||
|
|
||
|
|
||
| static NSString *const kRNConcurrentRoot = @"concurrentRoot"; | ||
| #else | ||
| // Modern path (RN >= 0.79) — RCTAppSetupUtils.h imported above | ||
| #endif | ||
|
|
||
| #if !RNN_RN_VERSION_79_OR_NEWER | ||
| @interface RNNAppDelegate () <RCTTurboModuleManagerDelegate, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,15 @@ | ||
| #import "RNNModalManager.h" | ||
| #import <Foundation/Foundation.h> | ||
| #ifndef RCT_NEW_ARCH_ENABLED | ||
| #import <React/RCTModalHostViewManager.h> | ||
| #endif | ||
|
|
||
| @interface RNNModalHostViewManagerHandler : NSObject | ||
|
|
||
| - (instancetype)initWithModalManager:(RNNModalManager *)modalManager; | ||
|
|
||
| #ifndef RCT_NEW_ARCH_ENABLED | ||
| - (void)connectModalHostViewManager:(RCTModalHostViewManager *)modalHostViewManager; | ||
| #endif | ||
|
|
||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| #import "RNNOverlayOptions.h" | ||
| #import <React/RCTRootView.h> | ||
|
|
||
| @implementation RNNOverlayOptions | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add
RCT_NEW_ARCH_ENABLED, we only support NEW_ARCH since RN 0.76. Especially DON'T add#ifndef RCT_NEW_ARCH_ENABLEDSo please remove all RCT_NEW_ARCH_ENABLED flags you added.