feat(Android): RN 76 new arch for Android #7965

gosha212 · 2025-01-28T16:05:19Z

Resolves #7966

Fixed ios pod file

This reverts commit 1ed449b.

# Conflicts: # lib/android/app/src/main/java/com/reactnativenavigation/react/ReactView.java # lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/RootPresenter.java # lib/ios/RNNStackPresenter.m # package.json

Change genymotion emulator

gosha212 · 2025-02-20T15:01:10Z

The work for Android is Done

erennyuksell · 2025-03-03T10:22:46Z

Hi, thank you for your hard work. When will this pr be merged and released in the next version? Is there an estimated time?

gosha212 · 2025-03-03T11:59:07Z

@erennyuksell we are going to release a new version with Android and iOS support of new arch.
The Android implementation is finished and we are actively working on the iOS implementation. It still has a lot of issues and we can't commit to any specific timeline. My estimation is about 2 weeks - 2 month for the first RC version for both platforms.

d4vidi

Notes and suggestions - for ~now
Test @Igore's - discuss offline

scripts/start.js

playground/android/settings.gradle

package.json

e2e/StaticLifecycleEvents.test.js

lib/android/app/src/main/java/com/reactnativenavigation/options/LayoutFactory.java

lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationReactInitializer.java

lib/android/app/src/main/java/com/reactnativenavigation/react/ReactView.java

…ReactView.java Co-authored-by: d4vidi <amit.d4vidi@gmail.com>

…s/LayoutFactory.java Co-authored-by: d4vidi <amit.d4vidi@gmail.com>

Co-authored-by: d4vidi <amit.d4vidi@gmail.com>

# Conflicts: # lib/android/app/src/test/java/com/reactnativenavigation/mocks/TitleBarReactViewCreatorMock.java

…feat/rn77-android-newarch

gosha212 · 2025-04-08T08:01:57Z

First preview of new arch is out https://github.com/wix/react-native-navigation/releases/tag/8.1.0-alpha01

peteAhn · 2025-04-08T12:12:02Z

First preview of new arch is out https://github.com/wix/react-native-navigation/releases/tag/8.1.0-alpha01

It happened android compile error

CMake Error at app/node_modules/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake:103 (target_link_libraries):
    Cannot specify link libraries for target "react_codegen_rnnavigation" which
    is not built by this project.
  Call Stack (most recent call first):
    CMakeLists.txt:31 (include)
at com.android.build.gradle.internal.cxx.process.ExecuteProcessKt.execute(ExecuteProcess.kt:288)
  	at com.android.build.gradle.internal.cxx.process.ExecuteProcessKt$executeProcess$1.invoke(ExecuteProcess.kt:108)
  	at com.android.build.gradle.internal.cxx.process.ExecuteProcessKt$executeProcess$1.invoke(ExecuteProcess.kt:106)
  	at com.android.build.gradle.internal.cxx.timing.TimingEnvironmentKt.time(TimingEnvironment.kt:32)

* auto renaming * changes * native fixes - passes build with manual change in RCTAppSetupUtils.h * all works still with change in RCTAppSetupUtils * loads the menu - playground works * fixed event receivers * hermes falg * fix side menu pres test * test ot .mm * comment out test that fail linkage * fix testSetRoot_withAnimation and testPush_shouldResolvePromiseAndSendCommandCompletionWithPushedComponentId * fix linking by a hack * remove invalidation * fix Stub in Turbo Module * Fix StaticLifecycleEvents tests * Delay will appear and did appear when component not already mounted * Update RNNReactView to use RCTSurfacePresenterStub and adjust component lifecycle methods for new architecture * Better implementation * Fix buttons * Fix button order test * Another buttons fix * Refactor component lifecycle methods in RNNReactButtonView and RNNReactView * fix snapshot c++ error * fix snapshot refactor mm * fix snapshot c code * view controller factory * moved turbo module spec to async * codegen type * cleanup native sender * Fixed types * adjust interface * fix remaining e2e * another test bites the dust * Disable failing E2E, failing snapshot and Turbo Modules on Android * comment ios test out * wrong test * Fixed android screenshot * Update package.json version to 8.1.0-alpha01 [buildkite skip] * Update package.json version to 8.1.0-alpha [buildkite skip] * Android Turbo Modules (#7999) * Implemented turbo modules for android * Implemented missing method * Complete Android Turbo module implementation * Complete Android Turbo module implementation * Undo some unneeded fixes * Fixed build on ios * WIP (cherry picked from commit c8a2fad) * Revert "WIP" This reverts commit 497ebd6. * Feat/rn 76 to 77 upgrade (#8005) * WIP * Update package-lock.json * Fixed ios build * Fixed unit tests * Fixed ios build * Fixed ios build * Revert "Fixed ios build" This reverts commit 3dbd98a. * Fixed ios build * fix tests for ios * Fixed eslint * DO NOT RELEASE THIS COMMIT! * Revert "DO NOT RELEASE THIS COMMIT!" This reverts commit b0e840e. * Fixed build for ios 77 * Fixed android turbo modules generation and autolinking (#8006) * iOS: RN 77 no lifecycle events for Top Bar Title component (#8015) The problem was that when setting a titleView of a navigationItem the normal life cycle flow of a view will not be called so the RNNReactView componentWillAppear and DidAppear need to be implicitly called. This was somehow removed from the TopBarTitlePresenter.mm unit but is present on the current Master branch's file. This PR restores those two lines and also actives the Unit test for that module. * Better alignment of willAppear and didAppear events throughout the lifecycle (#8019) * Better alignment of willAppear and didAppear events throughout the lifecycle * clean up of logs and polymorphism. * Reverting some changes * Update for NavigationTests. Two tests still fail, RNNCommandsHandlerTest and RNNModalManagerEventHandlerTest, which in this push are disabled. * Fixing pr * More fixes for PR --------- Co-authored-by: yogevbd <yogev132@gmail.com> Co-authored-by: Georgy Steshin <georgys@wix.com> Co-authored-by: undefined <undefined> Co-authored-by: mobileoss <mobileoss@wix.com> Co-authored-by: Georgy Steshin <gosha212@gmail.com> Co-authored-by: markdevocht <50657916+markdevocht@users.noreply.github.com>

# Conflicts: # package-lock.json

gosha212 added 30 commits January 27, 2025 16:41

Upgraded android to work with rn 77

2a776db

Upgraded to the latest version of detox

100dd5b

Added react types.

c742e3b

Fixed ios pod file

Updated pod filke

aee806a

Fixed es lint error

cacd4fe

Upgraded reanimated

419eed1

Fixed ios build

6f2ca4c

Fixed ios build

fd97ab2

Fixed one test in android

5dcf7c6

Fixed android tests

cc25411

Fixed android unit tests

e036898

Fixed android unit tests

24144b1

Fixed android tests

68cce81

Fixed mocked tests

534dbb7

Implemented new arch support for android

a1a64a6

Added new version of detox to support new arch

4763f14

Downgrade to RN 76

e719a90

support ios

ff9ed27

fixed android screenshot

7183b68

fixed android screenshot

550a73f

Reimplemented missing bar style in iOS

81f1eb6

Reimplemented missing bar style in iOS

2000684

Fixed ios bar styling

6b32776

Removed unused library

560f994

Upgraded roboletric to run on updated sdk

1ed449b

Revert "Upgraded roboletric to run on updated sdk"

a199c01

This reverts commit 1ed449b.

Merge rn76 old arch branch

23dace4

Fixed ios build

8227eb6

Fixed android modal

13c2b9e

gosha212 added 6 commits February 19, 2025 16:44

Fixed tests

570d31f

Change genymotion emulator

Fixed screenshot tolerance

15fdf3b

Fixed screenshot tolerance

9cefa10

Fixed screenshot tolerance algorithm

6acac33

Fixed screenshots for genymotion

6e316b1

Fixed modal test

bbfa701

gosha212 changed the title ~~Feat/rn77 android newarch~~ feat(Android): RN 76 new arch for Android Feb 20, 2025

d4vidi linked an issue Feb 20, 2025 that may be closed by this pull request

React Native 76 - new arch (android) #7966

Closed

gosha212 changed the base branch from feat/rn77 to master March 3, 2025 17:22

d4vidi requested changes Mar 4, 2025

View reviewed changes

gosha212 and others added 9 commits March 23, 2025 16:15

Update lib/android/app/src/main/java/com/reactnativenavigation/react/…

07c6ae1

…ReactView.java Co-authored-by: d4vidi <amit.d4vidi@gmail.com>

Update lib/android/app/src/main/java/com/reactnativenavigation/option…

43d3785

…s/LayoutFactory.java Co-authored-by: d4vidi <amit.d4vidi@gmail.com>

Update lib/android/app/src/main/java/com/reactnativenavigation/option…

00f52a6

…s/LayoutFactory.java Co-authored-by: d4vidi <amit.d4vidi@gmail.com>

Update playground/android/settings.gradle

4b12594

Co-authored-by: d4vidi <amit.d4vidi@gmail.com>

Fixes after PR

7471e36

Merge branch 'master' into feat/rn77-android-newarch

1df9f51

# Conflicts: # lib/android/app/src/test/java/com/reactnativenavigation/mocks/TitleBarReactViewCreatorMock.java

Fixed android build

d097e75

Fixed compilation error

b1780eb

Merge remote-tracking branch 'origin/feat/rn77-android-newarch' into …

fedaf89

…feat/rn77-android-newarch

gosha212 and others added 3 commits April 10, 2025 17:45

Fixed typing issue

e11fd53

Merge branch 'master' into feat/rn77-android-newarch

dcf82bc

# Conflicts: # package-lock.json

gosha212 added the type: accepted/enhancement label May 15, 2025

gosha212 merged commit e06cc38 into master May 15, 2025
4 of 5 checks passed

gosha212 deleted the feat/rn77-android-newarch branch May 15, 2025 08:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Android): RN 76 new arch for Android #7965

feat(Android): RN 76 new arch for Android #7965

gosha212 commented Jan 28, 2025 •

edited by d4vidi

Loading

gosha212 commented Feb 20, 2025

erennyuksell commented Mar 3, 2025

gosha212 commented Mar 3, 2025

d4vidi left a comment

gosha212 commented Apr 8, 2025

peteAhn commented Apr 8, 2025 •

edited

Loading

feat(Android): RN 76 new arch for Android #7965

feat(Android): RN 76 new arch for Android #7965

Conversation

gosha212 commented Jan 28, 2025 • edited by d4vidi Loading

gosha212 commented Feb 20, 2025

erennyuksell commented Mar 3, 2025

gosha212 commented Mar 3, 2025

d4vidi left a comment

Choose a reason for hiding this comment

gosha212 commented Apr 8, 2025

peteAhn commented Apr 8, 2025 • edited Loading

gosha212 commented Jan 28, 2025 •

edited by d4vidi

Loading

peteAhn commented Apr 8, 2025 •

edited

Loading